[Repository Listing] / [Wireshark]
Wireshark development

We've moved to Git

On January 28, 2014 we migrated from Subversion to Git. Please go to our code review site for current development activity.

Revision 50450

Jump to revision: Previous Next
Author: morriss
Date: Mon Jul 8 21:12:06 2013 UTC (2 years, 11 months ago)
Log Message:
Fix the very long loop reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8911 :

In parseFields() ensure that we have at least one byte so that callers
don't have to protect against it returning an offset which hasn't incremented.

Remove a couple of now-unnecessary length-remaining (aka "will the offset
move?") checks.

In some other checks, use tvb_ensure_length_remaining() rather than calling
tvb_length_remaining() and (potentially) THROWing an exception.  I'm not sure
if these are really necessary now or not...

Changed paths

Path Action
trunk/epan/dissectors/packet-dis-pdus.c trunk/epan/dissectors/packet-dis-pdus.c modified Revision Log
Diff to Previous

webmaster [at] wireshark.org
Tango Icons © Tango Desktop Project. Subversion  TortoiseSVN  ViewVC