[Repository Listing] / [Wireshark]
Wireshark development

We've moved to Git

On January 28, 2014 we migrated from Subversion to Git. Please go to our code review site for current development activity.

Revision 49744

Jump to revision: Previous Next
Author: morriss
Date: Tue Jun 4 02:01:53 2013 UTC (3 years ago)
Log Message:
Fix the fuzz failure reported (by me) in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8764 :

Apply the fix from bug 8539 (r48796) to another function (dissect_r3_upstreamcommand_queryconfig()):

Bail out of the item length we get (which we use to increment the offset) is 0.
Otherwise the offset does not advance and we loop forever.

While we're in there: get the item length just once (there's no need to call
tvb_get_guint8() a half dozen times when one will do).

Changed paths

Path Action
trunk/epan/dissectors/packet-assa_r3.c trunk/epan/dissectors/packet-assa_r3.c modified Revision Log
Diff to Previous

webmaster [at] wireshark.org
Tango Icons © Tango Desktop Project. Subversion  TortoiseSVN  ViewVC